-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFIQ Analyzer Implementation #3178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dynamic import of analyzers * Integration into the analyzer framework * Trigger via DFIQ Approaches being added to a sketch
* Linked Analysis with Approach objects * Trigger chck for analysis from the API Endpoint * Remove Signals (no need anymore) * Add open TODOs
* Restructured the dfiq_plugins/manager to be more versatile. * Adding a function to deregister analyzers to the manager * Ensuring the index is ready before analyzers are executed
berggren
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round. Looks good, some minor comments
berggren
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5 tasks
Going to merge the current state and track next steps in #3198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new DFIQ (Digital Forensics Investigative Questions) Analyzer framework to Timesketch, enabling the execution of analyzers based on investigative approaches defined in DFIQ objects.
What existing problem does this PR solve?
This PR addresses the need to integrate automated analysis workflows based on structured investigative methodologies like DFIQ. It provides a way to automatically trigger relevant analyzers when a user adds DFIQ approaches to a sketch.
What new feature is being introduced with this PR?
Analysis
andInvestigativeQuestionApproach
models, enabling tracking of analyses related to specific approaches.Overview of changes to existing functions if required:
Analysis
model has been extended to include an optional relationship withInvestigativeQuestionApproach
.tasks.py
file now supports DFIQ analyzer execution.DFIQAnalyzerManager
class has been added to handle the execution of DFIQ analyzers.TODOs:
This implementation provides a foundation for more advanced DFIQ-driven analysis workflows in Timesketch, allowing users to leverage structured methodologies for more efficient and guided investigations.
(The frontend part of this feature will be handled in a separate PR)